From commits-return-13041-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Thu May 7 07:51:18 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EBFC918062B for ; Thu, 7 May 2020 09:51:17 +0200 (CEST) Received: (qmail 63922 invoked by uid 500); 7 May 2020 07:51:17 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 63910 invoked by uid 99); 7 May 2020 07:51:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2020 07:51:17 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_maheshambule_commented_on_pull_re?= =?utf-8?q?quest_=235486=3A_=5BTFLITE=5DSelect_op_support_for_tflite_fronten?= =?utf-8?q?d?= Message-ID: <158883787730.26397.14510389576997553577.asfpy@gitbox.apache.org> Date: Thu, 07 May 2020 07:51:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: maheshambule commented on pull request #5486: URL: https://github.com/apache/incubator-tvm/pull/5486#issuecomment-625091810 > LGTM. @siju-samuel After thinking about this pr, I think we should make `get_expr` and `exp_tab.new_const` be private and only public `get_tensor_expr`. Other places use `get_expr` / `exp_tab.new_const` should be replaced as `get_tensor_expr`. Wish you could consider this suggestion after this pr. @FrozenGene, @siju-samuel, Considering this fix as part of this refactoring https://github.com/apache/incubator-tvm/pull/5528. Please let us know your opinions on other refactoring aspects as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org