From commits-return-12930-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Wed May 6 05:17:01 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2C521180626 for ; Wed, 6 May 2020 07:17:01 +0200 (CEST) Received: (qmail 71682 invoked by uid 500); 6 May 2020 05:17:00 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 71672 invoked by uid 99); 6 May 2020 05:17:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2020 05:17:00 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_zhiics_commented_on_a_change_in_p?= =?utf-8?q?ull_request_=235517=3A_=5BRUNTIME=5D_Improve_PackedFunc_robustnes?= =?utf-8?q?s?= Message-ID: <158874222013.26397.4792689536107038255.asfpy@gitbox.apache.org> Date: Wed, 06 May 2020 05:17:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: zhiics commented on a change in pull request #5517: URL: https://github.com/apache/incubator-tvm/pull/5517#discussion_r420549748 ########## File path: include/tvm/runtime/packed_func.h ########## @@ -45,6 +45,15 @@ #define TVM_RUNTIME_HEADER_ONLY 0 #endif +// Always inline macro only use in template +// expansion cases where we know inline is important. +#ifdef _MSC_VER +#define TVM_ALWAYS_INLINE __forceinline inline +#pragma warning(disable : 4068) Review comment: Just curious, which warning are we disabling here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org