From commits-return-12871-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Tue May 5 17:21:07 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2864A180626 for ; Tue, 5 May 2020 19:21:07 +0200 (CEST) Received: (qmail 36340 invoked by uid 500); 5 May 2020 17:21:06 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 36331 invoked by uid 99); 5 May 2020 17:21:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2020 17:21:06 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_siju-samuel_commented_on_a_change?= =?utf-8?q?_in_pull_request_=235479=3A_=5BRelay-TFLite=5D_FP32_and_Quantized?= =?utf-8?q?_Object_Detection_Model?= Message-ID: <158869926655.26397.6812714083898159780.asfpy@gitbox.apache.org> Date: Tue, 05 May 2020 17:21:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: siju-samuel commented on a change in pull request #5479: URL: https://github.com/apache/incubator-tvm/pull/5479#discussion_r420274518 ########## File path: python/tvm/relay/testing/tf.py ########## @@ -184,10 +184,15 @@ def get_workload_official(model_url, model_sub_path): dir_path = os.path.dirname(model_path) import tarfile + import zipfile Review comment: suggest to move this imports inside if or elif. let it import based on file type. ########## File path: tests/python/frontend/tflite/test_forward.py ########## @@ -1942,6 +1960,100 @@ def test_forward_qnn_mobilenet_v3_net(): tvm.testing.assert_allclose(tvm_sorted_labels, tflite_sorted_labels) +####################################################################### +# Quantized SSD Mobilenet +# ------------- Review comment: nit , align the dashes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org