From commits-return-12770-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Mon May 4 17:55:24 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EB93D180608 for ; Mon, 4 May 2020 19:55:23 +0200 (CEST) Received: (qmail 31722 invoked by uid 500); 4 May 2020 17:55:23 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 31712 invoked by uid 99); 4 May 2020 17:55:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2020 17:55:23 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_areusch_commented_on_a_change_in_?= =?utf-8?q?pull_request_=235484=3A_=5BREFACTOR=5D=5BRPC=5D=5BPROCOTOL-CHANGE?= =?utf-8?q?=5D_Modularize_the_RPC_infra?= Message-ID: <158861492332.26397.15147774449887116438.asfpy@gitbox.apache.org> Date: Mon, 04 May 2020 17:55:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419619088 ########## File path: python/tvm/rpc/client.py ########## @@ -378,7 +402,7 @@ def request_and_run(self, key, max_retry, str(last_err))) -def connect(url, port, key="", session_timeout=0): +def connect(url, port, key="", session_timeout=0, session_constructor=None): Review comment: maybe we can call it session_constructor_args so it's more clear it should be a list rather than a callable? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org