From commits-return-12659-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Fri May 1 17:22:58 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 78577180634 for ; Fri, 1 May 2020 19:22:58 +0200 (CEST) Received: (qmail 87514 invoked by uid 500); 1 May 2020 17:22:58 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 87505 invoked by uid 99); 1 May 2020 17:22:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 May 2020 17:22:57 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_weberlo_commented_on_a_change_in_?= =?utf-8?q?pull_request_=235417=3A_=5BRUNTIME=5D=5BuTVM=5D_AutoTVM_+_uTVM_fo?= =?utf-8?q?r_Cortex-M7?= Message-ID: <158835377780.26397.14544419891319180252.asfpy@gitbox.apache.org> Date: Fri, 01 May 2020 17:22:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: weberlo commented on a change in pull request #5417: URL: https://github.com/apache/incubator-tvm/pull/5417#discussion_r418643505 ########## File path: src/runtime/micro/openocd_low_level_device.cc ########## @@ -210,9 +210,9 @@ class OpenOCDLowLevelDevice final : public LowLevelDevice { // NOTE: OpenOCD will call any request larger than this constant an "absurd // request". /*! \brief maximum number of bytes allowed in a single memory transfer */ - static const constexpr ssize_t kMemTransferLimit = 64000; + static const constexpr ssize_t kMemTransferLimit = 8000; Review comment: okay. we might want some preprocessor magic to detect if the platform is linux or mac and set this constant accordingly, because leaving it at 8k means linux is issuing 8 times more requests than needs to. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org