tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] masahi opened a new pull request #5552: [BYOC, MergeComposite] Add additional check before re-using the cached match
Date Sun, 10 May 2020 04:19:50 GMT

masahi opened a new pull request #5552:
URL: https://github.com/apache/incubator-tvm/pull/5552


   I found a bug in the merge composite pass where the pattern on the left incorrectly matches
the structure on the right, returning a composite function without the intermediate `add`
op.
   
   ```
      pattern          target
   
       relu             relu
        | \              | \
        | clip           | add
        |  /             |  |
        mul              | clip
                         |  /
                         mul
   ```
   
   This happens because when MergeComposite found `relu` in the pattern for the second time
as an argument of `clip`, it simply reuses the match result from the first time `relu` was
found as an argument of `mul`. But since the target of `clip` in the target is not `relu`,
re-using the cached match in this case is not right.
   
   Please review @mbaret @lhutton1 @zhiics @comaniac 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message