tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] comaniac edited a comment on pull request #5689: [PatternLang] Add ConstantPattern
Date Thu, 28 May 2020 23:38:38 GMT

comaniac edited a comment on pull request #5689:
URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635672040


   OK so here is a conclusion for another follow-up PR to deal with constant lifting.
   
   - Pattern input `ConstantPattern`:
       - Only match constant nodes and keep them in the partitioned functions. In this case,
the arguments of partitioned functions will be reduced.
   - Pattern input `VarPattern('x')`:
       - Match only the var node with a specified name hint. In this case, the arguments of
partitioned function is fixed.
   - Pattern input `wildcard` or `VarPattern('x') | ConstantPattern`:
       - Match both constant and var node but life constant nodes. In this case, the arguments
of partitioned function is fixed whever it matches constant or var.
   
   btw, IMHO, for clearer semantic, it might be better if we support `VarPattern()` that matches
a var node with any name hints but not constant node.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message