tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] mbaret commented on pull request #5689: [PatternLang] Add ConstantPattern
Date Thu, 28 May 2020 23:15:03 GMT

mbaret commented on pull request #5689:
URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635665317


   It's not really the case that old merge composite explicitly 'lifts' constant nodes if
they're vars, in old merge composite vars indicate inputs to the pattern (so they don't need
to explicitly match against a VarNode).
   
   My expectation would be if the pattern requires there to be a constant node, I should see
that constant node in the partitioned function. In other words, the body of the function should
still match the pattern used to create it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message