tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] mbrookhart edited a comment on pull request #5689: [PatternLang] Add ConstantPattern
Date Thu, 28 May 2020 22:45:47 GMT

mbrookhart edited a comment on pull request #5689:
URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635646234


   :point_up: I'll let you guys discuss the appropriate behavior, there's seems to be some
complication to this. 
   
   In the mean time, this was my initial assumption:
   
   > I expect constants to be available to external codegen at compile time. Otherwise
we cannot do constant folding.
   
   But it doesn't match the fusion pass.
   
   > I think the most logical behaviour is for constants to remain embedded where they
are explicitly part of the pattern and to lift them where they are not.
   
   I think about how to do that. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message