tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] comaniac commented on pull request #5689: [PatternLang] Add ConstantPattern
Date Thu, 28 May 2020 22:18:06 GMT

comaniac commented on pull request #5689:
URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635637903


   > Thanks for the PR so soon! Is there an example of how partition works on a constant
match? In particular, does the constant remain propagated into the body?
   
   An example can be found in the unit test: https://github.com/apache/incubator-tvm/pull/5689/files#diff-f9920485e5e341787129348ce1985db9R213
   
   Also, could you provide an example to show your expection of constant propogation?
   
   > 
   > On a general point, it's helpful if reformats are kept separate from feature additions
for reviews so it's easy to see what the changes are.
   
   Yeah the bugfix should be put to a separate PR for sure. For re-formatting, I didn't intentionally
reformat the unit test file. VSCode by default auto-formats the file once I paste some code.
I was even considering to revert auto-formatting due to the reason you pointed out. However,
I checked the re-formatting and it is mostly just blank and too-long lines, so I think it
should be fine for this small feature PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message