tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] dprankratz commented on pull request #5666: [TIR][Bugfix] Improved massive build times caused by tir.floormod and tir.floordiv. Fixed Topi testcase.
Date Mon, 25 May 2020 01:54:46 GMT

dprankratz commented on pull request #5666:
URL: https://github.com/apache/incubator-tvm/pull/5666#issuecomment-633339239


   @tqchen I'm not sure how to gracefully add a LetNode since I'm running into trouble creating
a variable with a unique name. For example, using a simple counter to create variables of
the form `temp0`, `temp1` will run into problems when multiple expressions exist concurrently
and the names conflict causing SSA form to be broken. 
   
   I've tried searching for other places where this is handled and haven't seen anything which
makes me uneasy. Any suggestions?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message