tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5654: [REFACTOR][IR] Migrate IRModule ObjectRef to not-null
Date Fri, 22 May 2020 17:58:28 GMT

ANSHUMAN87 commented on pull request #5654:
URL: https://github.com/apache/incubator-tvm/pull/5654#issuecomment-632830825


   There are 2 approaches followed here to solve Optional issue in exposed APIs.
   A0: Using Optional<T> way as mentioned in the reference link. (Ref src/relay/analysis/feature.cc)
   A1: Making API user provide Empty IRModule. (Ref python/tvm/relay/transform/transform.py)
   
   Please let me know, if we should follow only A0 strictly. TIA!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message