tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] vinx13 commented on a change in pull request #5628: [Relay, Topi][OP] Correlation
Date Thu, 21 May 2020 18:18:56 GMT

vinx13 commented on a change in pull request #5628:
URL: https://github.com/apache/incubator-tvm/pull/5628#discussion_r428829546



##########
File path: include/tvm/relay/attrs/nn.h
##########
@@ -1203,6 +1203,36 @@ struct SubPixelAttrs : public tvm::AttrsNode<SubPixelAttrs> {
   }
 };  // struct SubPixelAttrs
 
+/*! \brief Attributes used in correlation operators */
+struct CorrelationAttrs : public tvm::AttrsNode<CorrelationAttrs> {
+  int kernel_size;
+  int max_displacement;
+  int stride1;
+  int stride2;
+  Array<IndexExpr> padding;

Review comment:
       I'm using the helper function `void GetPaddingHeightWidth(const Array<IndexExpr>&
padding, IndexExpr* pad_h,
                                     IndexExpr* pad_w)'` which is also used by convolution.
What about keeping `Array<IndexExpr>` so that we can migrate to `Array<Integer>`
at once in the future?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message