tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] masahi edited a comment on pull request #5627: Label Pattern Partitions
Date Wed, 20 May 2020 20:16:16 GMT

masahi edited a comment on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631693138


   @mbrookhart Can you define this attribute in a public header? Since it will be looked up
by backends like this
   https://github.com/apache/incubator-tvm/blob/master/src/relay/backend/contrib/dnnl/codegen.cc#L248
   
   Add the new attribute here https://github.com/apache/incubator-tvm/blob/master/include/tvm/relay/function.h#L144
   
   It is also better to use `kPartittionedFromPatten` inside dataflow_matcher.cc, rather than
repeating raw string.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message