tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] junrushao1994 edited a comment on pull request #5585: [Runtime] Introduce runtime::Array
Date Tue, 19 May 2020 23:53:27 GMT

junrushao1994 edited a comment on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-631147088


   Given the fact that `dmlc::LogMessageFatal` causes significant amount of increase in stack
size, we investigated into dmlc-core.
   
   Our initial result: if we change `dmlc::LogMessageFatal` to `std::unique_ptr<dmlc::LogMessageFatal>`:
in `CommonSubexprEliminator`,  we can reduce (upper bound of) the stack frame size from 4720
to 560:
   
   ```
   # master
   virtual tvm::relay::Expr tvm::relay::CommonSubexprEliminator::VisitExpr_(const tvm::relay::CallNode*)
1072	static
   # before patch dmlc-core
   virtual tvm::relay::Expr tvm::relay::CommonSubexprEliminator::VisitExpr_(const tvm::relay::CallNode*)
4720	dynamic,bounded
   # after patch dmlc-core
   virtual tvm::relay::Expr tvm::relay::CommonSubexprEliminator::VisitExpr_(const tvm::relay::CallNode*)
560	dynamic,bounded
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message