tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5622: [Replay] Move compiler_begin/end_op to local static objects
Date Tue, 19 May 2020 14:30:13 GMT

tqchen commented on a change in pull request #5622:
URL: https://github.com/apache/incubator-tvm/pull/5622#discussion_r427348052



##########
File path: src/relay/transforms/pass_util.h
##########
@@ -115,6 +115,20 @@ inline bool IsAtomic(const Expr& e) {
   return e.as<VarNode>() || e.as<OpNode>() || e.as<ConstructorNode>() ||
e.as<GlobalVarNode>();
 }
 
+/*!
+ * \brief Cache the compiler_begin annotation op to reduce registry lookup overhead
+ * \param void
+ * \return compiler_begin op
+ */
+const Op& compiler_begin_op();

Review comment:
       Use CamelCase




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message