tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] windclarion commented on a change in pull request #5623: root->args[i] isn't a CallNode sometimes
Date Tue, 19 May 2020 12:38:32 GMT

windclarion commented on a change in pull request #5623:
URL: https://github.com/apache/incubator-tvm/pull/5623#discussion_r427268341



##########
File path: src/relay/transforms/merge_composite.cc
##########
@@ -122,8 +122,10 @@ class MergeCompositeWrapper : public ExprMutator {
     for (const auto& arg : pattern->args) {
       Expr new_arg;
       if (arg->IsInstance<CallNode>()) {
-        new_arg =
-            ExtractPattern(Downcast<Call>(arg), Downcast<Call>(root->args[i]),
var_map, call_map);
+        if (root->args[i]->IsInstance<CallNode>()) {

Review comment:
       if move to L124, then L133  "call_map->Set(arg, new_arg)" will not be executed.
I'm not sure if we can bypass the L133 if  arg is CallNode and root->args[i]  is not CallNode.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message