tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5547: [Refactor][std::string --> String] IR is updated with String
Date Sun, 10 May 2020 05:26:05 GMT

ANSHUMAN87 commented on a change in pull request #5547:
URL: https://github.com/apache/incubator-tvm/pull/5547#discussion_r422587536



##########
File path: src/ir/attrs.cc
##########
@@ -53,9 +53,13 @@ Array<AttrFieldInfo> DictAttrsNode::ListFieldInfo() const {
   return {};
 }
 
-DictAttrs::DictAttrs(Map<std::string, ObjectRef> dict) {
+DictAttrs::DictAttrs(Map<String, ObjectRef> dict) {
   ObjectPtr<DictAttrsNode> n = make_object<DictAttrsNode>();
-  n->dict = std::move(dict);
+  Map<std::string, ObjectRef> dict_copy;
+  for (auto iter : dict) {

Review comment:
       @tqchen : You are right! It was an effort to isolate independent commits, so that the
dependency can be broken down. Will revert it for now!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message