tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] cchung100m commented on a change in pull request #5501: [TIR][REFACTOR] std::string -> String Migration in TIR nodes
Date Sat, 09 May 2020 18:08:24 GMT

cchung100m commented on a change in pull request #5501:
URL: https://github.com/apache/incubator-tvm/pull/5501#discussion_r422527378



##########
File path: src/target/llvm/codegen_llvm.cc
##########
@@ -685,11 +685,11 @@ llvm::Value* CodeGenLLVM::CreateCallExtern(const CallNode* op) {
   }
   llvm::FunctionType* ftype = llvm::FunctionType::get(
       GetLLVMType(GetRef<PrimExpr>(op)), arg_type, false);
-  llvm::Function* f = module_->getFunction(op->name);
+  llvm::Function* f = module_->getFunction((std::string)op->name);

Review comment:
       Hi @zhiics ,
   
   Thanks for your kind reminder. I change the C-style explicit casting with `op->name.c_str()`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message