tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] liangfu commented on a change in pull request #5492: [RUNTIME] Hexagon driver for offloading kernels to simulator
Date Fri, 08 May 2020 01:21:31 GMT

liangfu commented on a change in pull request #5492:
URL: https://github.com/apache/incubator-tvm/pull/5492#discussion_r421883580



##########
File path: src/runtime/hexagon/sim/driver/CMakeLists.txt
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       I don't have strong opinion on this, but suggest to improve the experience of potential
users. They suppose to turn USE_HEXAGON_SIM_DRIVER flag ON in the [config.cmake](https://github.com/apache/incubator-tvm/blob/master/cmake/config.cmake)
to have this driver build automatically, instead of navigating to src/runtime/hexagon/sim/driver
and start another build configure again.
   
   To achieve this goal, 
   
   1. Rename this file to HexagonSimDriver.cmake, and have it included in the main CMakeLists.txt
   2. The following CMake config would be helpful to locate the hexagon-clang and have the
proposed sim driver correctly compiled.
   
   https://github.com/apache/incubator-tvm/blob/19f322d70335c13c0d4f7af15c684bd414b90b40/cmake/modules/Hexagon.cmake#L22
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message