tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] maheshambule commented on pull request #5486: [TFLITE]Select op support for tflite frontend
Date Thu, 07 May 2020 07:51:17 GMT

maheshambule commented on pull request #5486:
URL: https://github.com/apache/incubator-tvm/pull/5486#issuecomment-625091810


   > LGTM. @siju-samuel After thinking about this pr, I think we should make `get_expr`
and `exp_tab.new_const` be private and only public `get_tensor_expr`. Other places use `get_expr`
/ `exp_tab.new_const` should be replaced as `get_tensor_expr`. Wish you could consider this
suggestion after this pr.
   
   @FrozenGene, @siju-samuel, Considering this fix as part of this refactoring https://github.com/apache/incubator-tvm/pull/5528.
   
   Please let us know your opinions on other refactoring aspects as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message