tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5533: Cache ObjectPtr<PrimExprNode> instead of raw pointers in bound analyzer
Date Thu, 07 May 2020 01:16:48 GMT

tqchen commented on a change in pull request #5533:
URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421182713



##########
File path: include/tvm/arith/analyzer.h
##########
@@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef {
  */
 class ConstIntBoundAnalyzer {
  public:
+  using BoundMapType = std::unordered_map<ObjectPtr<const PrimExprNode>, ConstIntBound,
ObjectHash>;

Review comment:
       I think it can go both ways, given that the most reference types already have const
properties, perhaps we could remove `ObjectPtr<const>` for simplicity




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message