tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #5533: Cache ObjectPtr<PrimExprNode> instead of raw pointers in bound analyzer
Date Wed, 06 May 2020 22:35:31 GMT

kparzysz-quic commented on a change in pull request #5533:
URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421127973



##########
File path: include/tvm/arith/analyzer.h
##########
@@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef {
  */
 class ConstIntBoundAnalyzer {
  public:
+  using BoundMapType = std::unordered_map<ObjectPtr<const PrimExprNode>, ConstIntBound,
ObjectHash>;

Review comment:
       Wait, maybe I misunderstood.  `PrimExpr` instead of `PrimExprNode`?
   
   Edit: `PrimExpr` instead of `ObjectPtr<const PrimExprNode>`.  I think I got it now...
haha




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message