tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] jroesch commented on pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.
Date Wed, 06 May 2020 17:03:28 GMT

jroesch commented on pull request #5526:
URL: https://github.com/apache/incubator-tvm/pull/5526#issuecomment-624770902


   @nhynes thanks for the review. I opened this at like 2:30am last night before going to
bed. Will provide some more context.
   
   The goal of my refactor to is to turn on the new C-ABI compatible object system in TVM.
I started by trying to simplify the split between interfaces and better match TVM's linking
model. I found some of the code using the low-level `ffi::{X, Y}` types and some using higher-level
types, this first patch just combines the overlap without fully changing things to my liking
as in not to break everything. 
   
   What I first did is combine some overlapping code that I found in `tvm-frontend` and `tvm-common`
and then have been working on rectifying the top-level layers. If you want to see end-to-end
state you can see my WIP version at https://github.com/jroesch/tvm/tree/rust-fe. 
   
   A cool not yet polished thing is the ability to write an out of tree Rust pass. See https://github.com/jroesch/tvm/tree/rust-fe/rust/out-of-tree.

   
   I would like to land the initial layers in tree so I can start to turn on CI and incrementally
land instead of writing a single 10kloc PR. Hoping to do multiple passes on the naming, interface,
etc. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message