tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] zhiics commented on a change in pull request #5517: [RUNTIME] Improve PackedFunc robustness
Date Wed, 06 May 2020 05:17:00 GMT

zhiics commented on a change in pull request #5517:
URL: https://github.com/apache/incubator-tvm/pull/5517#discussion_r420549748



##########
File path: include/tvm/runtime/packed_func.h
##########
@@ -45,6 +45,15 @@
 #define TVM_RUNTIME_HEADER_ONLY 0
 #endif
 
+// Always inline macro only use in template
+// expansion cases where we know inline is important.
+#ifdef _MSC_VER
+#define TVM_ALWAYS_INLINE __forceinline inline
+#pragma warning(disable : 4068)

Review comment:
       Just curious, which warning are we disabling here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message