tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5516: [RPC][BUGFIX][BACKPORT-0.6] Fix bug in rpc ring buffer shrink
Date Tue, 05 May 2020 20:22:46 GMT

tqchen commented on a change in pull request #5516:
URL: https://github.com/apache/incubator-tvm/pull/5516#discussion_r420382680



##########
File path: tests/python/unittest/test_runtime_rpc.py
##########
@@ -102,6 +102,14 @@ def remote_array_func(y):
     fremote(r_cpu)
 
 
+def test_rpc_large_array_shrink():
+    server = rpc.Server("localhost")
+    remote = rpc.connect(server.host, server.port)
+    ctx = remote.cpu(0)
+    a = tvm.nd.array(np.ones((5041, 720)).astype('float32'), ctx)
+    b = tvm.nd.array(np.ones((720, 192)).astype('float32'), ctx)

Review comment:
       great pt, right now i am only copying the failure case of the large array. 
   
   However, the error is not exactly reproducible, because it depends on the internal state
of the RPC server. Atm I am only able to fix a potential bug but not sure if we could get
a exact regression.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message