tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5486: [TFLITE]Select op support for tflite frontend
Date Tue, 05 May 2020 17:39:09 GMT

siju-samuel commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-tvm/pull/5486#discussion_r420289173



##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -109,16 +109,17 @@ def __init__(self, model, subgraph, exp_tab):
             'PAD': self.convert_pad,
             'POW': self.convert_pow,
             'PRELU': self.convert_prelu,
-            'REDUCE_ANY': self._convert_reduce_any,
-            'REDUCE_MAX': self._convert_reduce_max,
-            'REDUCE_MIN': self._convert_reduce_min,
-            'REDUCE_PROD': self._convert_reduce_prod,
+            'REDUCE_ANY': self.convert_reduce_any,
+            'REDUCE_MAX': self.convert_reduce_max,
+            'REDUCE_MIN': self.convert_reduce_min,
+            'REDUCE_PROD': self.convert_reduce_prod,
             'RELU':self.convert_relu,

Review comment:
       @u99127 Thanks for the review. I totally agree with you. I removed those changes as
part of this PR. i will raise another PR[#5515] for those. Could you please check again. TIA.





----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message