tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5479: [Relay-TFLite] FP32 and Quantized Object Detection Model
Date Tue, 05 May 2020 17:21:06 GMT

siju-samuel commented on a change in pull request #5479:
URL: https://github.com/apache/incubator-tvm/pull/5479#discussion_r420274518



##########
File path: python/tvm/relay/testing/tf.py
##########
@@ -184,10 +184,15 @@ def get_workload_official(model_url, model_sub_path):
     dir_path = os.path.dirname(model_path)
 
     import tarfile
+    import zipfile

Review comment:
       suggest to move this imports inside if or elif. let it import based on file type.

##########
File path: tests/python/frontend/tflite/test_forward.py
##########
@@ -1942,6 +1960,100 @@ def test_forward_qnn_mobilenet_v3_net():
     tvm.testing.assert_allclose(tvm_sorted_labels, tflite_sorted_labels)
 
 
+#######################################################################
+# Quantized SSD Mobilenet
+# -------------

Review comment:
       nit , align the dashes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message