From commits-return-12555-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Thu Apr 30 12:44:18 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 76E26180630 for ; Thu, 30 Apr 2020 14:44:18 +0200 (CEST) Received: (qmail 59227 invoked by uid 500); 30 Apr 2020 12:44:17 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 59218 invoked by uid 99); 30 Apr 2020 12:44:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Apr 2020 12:44:17 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_Hzfengsy_commented_on_pull_reques?= =?utf-8?q?t_=235483=3A_=5BTIR=5D=5BPrinter=5D_text_format_printer_consideri?= =?utf-8?q?ng_future_parsing_use?= Message-ID: <158825065768.26397.5296797664310289848.asfpy@gitbox.apache.org> Date: Thu, 30 Apr 2020 12:44:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: Hzfengsy commented on pull request #5483: URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-621810131 Some comments: 1. There are more than one spaces before the left brace in the allocation line ``` allocate(B.local, float32, [64]) { ``` 2. Can we use the same rule for the allocation stmt as the one for attr? Allocation stmt now will bring extra indentation 3. ``` attr [IterVar(blockIdx.z: int32, [(nullptr)], "ThreadIndex", "blockIdx.z")] "thread_extent" = 196; ``` It is strange to print `nullptr` here especially in square brackets. Perhaps we can use `IterVar(blockIdx.z: int32, (nullptr), "ThreadIndex", "blockIdx.z")]` or `IterVar(blockIdx.z: int32, , "ThreadIndex", "blockIdx.z")]` 4. Considering future parsing use, we must print the dtype for every const number. But we may use some shorthand for common dtype. e.g. `2f` for float32, `2h` for float16(half), direct`2` for int32 (for here most integer numbers in schedule are int32). But still, keep the complete form for every type. e.g. `int8(2)`, `float64(2)`(or may be `fp64(2)`) , also, `float32(2)` is legal as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org