From commits-return-12473-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Wed Apr 29 14:21:36 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1592B180654 for ; Wed, 29 Apr 2020 16:21:35 +0200 (CEST) Received: (qmail 5843 invoked by uid 500); 29 Apr 2020 14:21:35 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 5826 invoked by uid 99); 29 Apr 2020 14:21:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2020 14:21:35 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_tqchen_edited_a_comment_on_pull_r?= =?utf-8?q?equest_=235465=3A_=5BTIR=5D_Convert_if=5Fthen=5Felse_intrinsics_t?= =?utf-8?q?o_if-statements?= Message-ID: <158817009544.3807.6549673461767119730.asfpy@gitbox.apache.org> Date: Wed, 29 Apr 2020 14:21:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: tqchen edited a comment on pull request #5465: URL: https://github.com/apache/incubator-tvm/pull/5465#issuecomment-621242357 Thanks @roastduck Given that it is a quit fundamental construct that can leads to concise generated code(e.g. ? in CUDA), I think we should keep it throughout the lowering process by default. We can still merge the pass if it is an optional utility If the goal is mainly to utilize LoopParition, perhaps a better way would be to insert likely into the condition and enable LoopPartition to deal with if_then_else. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org