From commits-return-12458-archive-asf-public=cust-asf.ponee.io@tvm.apache.org  Wed Apr 29 05:26:29 2020
Return-Path: <commits-return-12458-archive-asf-public=cust-asf.ponee.io@tvm.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 51A0318066D
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 29 Apr 2020 07:26:29 +0200 (CEST)
Received: (qmail 4218 invoked by uid 500); 29 Apr 2020 05:26:28 -0000
Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@tvm.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@tvm.apache.org>
List-Post: <mailto:commits@tvm.apache.org>
List-Id: <commits.tvm.apache.org>
Reply-To: dev@tvm.apache.org
Delivered-To: mailing list commits@tvm.apache.org
Received: (qmail 4183 invoked by uid 99); 29 Apr 2020 05:26:28 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2020 05:26:28 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: commits@tvm.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_icemelon9_commented_on_a_change_i?=
 =?utf-8?q?n_pull_request_=235459=3A_=5BRelay=5D=5BOp=5DSupport_symbolic_Top?=
 =?utf-8?q?K=2C_Ones=2C_Zeros_and_Full?=
Message-ID: <158813798859.3807.79879203921323450.asfpy@gitbox.apache.org>
Date: Wed, 29 Apr 2020 05:26:28 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
References: <incubator-tvm.5459.MDExOlB1bGxSZXF1ZXN0NDA5ODQ1Mzg5.gitbox@gitbox.apache.org>
In-Reply-To: <incubator-tvm.5459.MDExOlB1bGxSZXF1ZXN0NDA5ODQ1Mzg5.gitbox@gitbox.apache.org>


icemelon9 commented on a change in pull request #5459:
URL: https://github.com/apache/incubator-tvm/pull/5459#discussion_r417073724



##########
File path: include/tvm/relay/attrs/transform.h
##########
@@ -110,7 +110,7 @@ struct TakeAttrs : public tvm::AttrsNode<TakeAttrs> {
 
 /*! \brief Attributes that specify a tensor */
 struct InitOpAttrs : public tvm::AttrsNode<InitOpAttrs> {
-  Array<IndexExpr> shape;
+  Expr shape;

Review comment:
       same here.

##########
File path: include/tvm/relay/attrs/algorithm.h
##########
@@ -50,14 +50,14 @@ struct ArgsortAttrs : public tvm::AttrsNode<ArgsortAttrs> {
 };
 
 struct TopKAttrs : public tvm::AttrsNode<TopKAttrs> {
-  int k;
+  Expr k;

Review comment:
       Should we use `Optional<Integer>` here and it only holds value when input `k` is a constant?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org