From commits-return-11739-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Sun Apr 19 23:56:16 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3D369180630 for ; Mon, 20 Apr 2020 01:56:16 +0200 (CEST) Received: (qmail 36971 invoked by uid 500); 19 Apr 2020 23:56:15 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 36961 invoked by uid 99); 19 Apr 2020 23:56:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Apr 2020 23:56:15 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_kevinthesun_commented_on_a_change?= =?utf-8?q?_in_pull_request_=234312=3A_=5BTOPI=5D=5BRelay=5D=5BOP=5D_Dynamic?= =?utf-8?q?_NMS_and_strided=5Fslice?= Message-ID: <158734057548.29173.12701053982544423755.asfpy@gitbox.apache.org> Date: Sun, 19 Apr 2020 23:56:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: kevinthesun commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r411021266 ########## File path: src/relay/transforms/fuse_ops.cc ########## @@ -247,6 +247,28 @@ class IndexedForwardGraph::Creator : private ExprVisitor { this->Update(call->op, node, kOpaque); } + if (call->attrs.as()) { + bool is_dyn{false}; + for (auto arg : call->args) { + if (!arg.as()) { + is_dyn = true; + break; + } + auto arg_tt = arg->checked_type().as(); + if (arg_tt) { Review comment: Since we have already checked begin, end and stride through as, I think here we just need to check the first arg? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org