From commits-return-11478-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Wed Apr 15 16:48:54 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EED0918065C for ; Wed, 15 Apr 2020 18:48:53 +0200 (CEST) Received: (qmail 54888 invoked by uid 500); 15 Apr 2020 16:48:53 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 54879 invoked by uid 99); 15 Apr 2020 16:48:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2020 16:48:53 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] comaniac commented on issue #5277: [BYOC] Refine AnnotateTarget and MergeCompilerRegion Passes Message-ID: <158696933325.32558.7011024880955029668.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 15 Apr 2020 16:48:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit comaniac commented on issue #5277: [BYOC] Refine AnnotateTarget and MergeCompilerRegion Passes URL: https://github.com/apache/incubator-tvm/pull/5277#issuecomment-614153285 One reason that I exposed default between passes was to have a clear task division so that the flow would be more stable. For example, one bug about composite function reported in #5272 was because AnnotateTarget pass skipped composite functions but AnnotateRestDefault didn't, so the default annotations were mis-inserted and it results in segmentation fault when partitioning the graph. This may happen in the future if still we have more than one places doing similar tasks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services