From commits-return-11440-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Wed Apr 15 04:03:39 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8DC8518064F for ; Wed, 15 Apr 2020 06:03:39 +0200 (CEST) Received: (qmail 80514 invoked by uid 500); 15 Apr 2020 04:03:38 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 80489 invoked by uid 99); 15 Apr 2020 04:03:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2020 04:03:37 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] FrozenGene commented on issue #4857: Windows Support for cpp_rpc Message-ID: <158692341767.29212.10659529187626171046.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 15 Apr 2020 04:03:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit FrozenGene commented on issue #4857: Windows Support for cpp_rpc URL: https://github.com/apache/incubator-tvm/pull/4857#issuecomment-613803362 > > For CMake version, It is better to use the same version on Linux / Windows. We cold add it in compiler options in later pr. > > Removed all the extra CMakeLists.txt stuff I had in there and do a FATAL if USE_CPP_RPC is set on a non-Windows platform. > > Added instructions in the README. > > Two other things I want to check with you guys is the small modification I made to `src/support/ring_buffer.h`. The original would cause a crash on Windows. > > Also the same with `src/runtime/rpc/rpc_socket_impl.cc` change, which shouldn't be an issue (put try/catch in a destructor). i think it is fine ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services