From commits-return-11391-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Tue Apr 14 18:08:37 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C69F718064F for ; Tue, 14 Apr 2020 20:08:36 +0200 (CEST) Received: (qmail 63951 invoked by uid 500); 14 Apr 2020 18:08:36 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 63937 invoked by uid 99); 14 Apr 2020 18:08:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Apr 2020 18:08:36 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] trevor-m commented on a change in pull request #5320: [BYOC] Prevent duplicate outputs in subgraph Tuple Message-ID: <158688771605.576.13488645081532581073.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 14 Apr 2020 18:08:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit trevor-m commented on a change in pull request #5320: [BYOC] Prevent duplicate outputs in subgraph Tuple URL: https://github.com/apache/incubator-tvm/pull/5320#discussion_r408335691 ########## File path: tests/python/relay/test_annotated_regions.py ########## @@ -56,7 +56,7 @@ def test_region_set_creator_diamond(): 'test_target', [cb_1], [cb_1, O_1, ce_1, ce_2], - [ce_1, ce_2], Review comment: Thanks all, I've implemented proposal C with the latest commits. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services