From commits-return-11290-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Mon Apr 13 20:22:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8B80F18062C for ; Mon, 13 Apr 2020 22:22:31 +0200 (CEST) Received: (qmail 7730 invoked by uid 500); 13 Apr 2020 20:22:31 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 7715 invoked by uid 99); 13 Apr 2020 20:22:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Apr 2020 20:22:31 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] trevor-m commented on a change in pull request #5320: [BYOC] Prevent duplicate outputs in subgraph Tuple Message-ID: <158680935094.31026.11472754641951173712.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 13 Apr 2020 20:22:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit trevor-m commented on a change in pull request #5320: [BYOC] Prevent duplicate outputs in subgraph Tuple URL: https://github.com/apache/incubator-tvm/pull/5320#discussion_r407693736 ########## File path: tests/python/relay/test_annotated_regions.py ########## @@ -56,7 +56,7 @@ def test_region_set_creator_diamond(): 'test_target', [cb_1], [cb_1, O_1, ce_1, ce_2], - [ce_1, ce_2], Review comment: @mbaret @comaniac `ce_1` and `ce_2` are duplicates here. I had to make this change to this test to get it to pass after my fix. Is it important that AnnotatedRegions could have duplicate outputs? Is there a use case for annotatedRegions outside of the MergeCompilerRegions/PartitionGraph flow? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services