From commits-return-11018-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Fri Apr 10 06:56:45 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E752318057A for ; Fri, 10 Apr 2020 08:56:44 +0200 (CEST) Received: (qmail 86127 invoked by uid 500); 10 Apr 2020 06:56:44 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 86117 invoked by uid 99); 10 Apr 2020 06:56:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Apr 2020 06:56:44 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] hlu1 commented on issue #5301: [NDArray] Set NDArray::Container.shape_ in NDArray::FromDLPack Message-ID: <158650180424.6050.16015923041987381058.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 10 Apr 2020 06:56:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hlu1 commented on issue #5301: [NDArray] Set NDArray::Container.shape_ in NDArray::FromDLPack URL: https://github.com/apache/incubator-tvm/pull/5301#issuecomment-611907106 I'm referring to the case that DLManagedTensor.dl_tensor.shape which is an int64_t* could be pointing to an array that's allocated in the stack and not on the heap. People are usually pretty careful to make sure the data is allocated on the heap and properly deleted in the deleter, but forget to do the same for the shape info. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services