From commits-return-10893-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Thu Apr 9 04:35:24 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1972B18057A for ; Thu, 9 Apr 2020 06:35:24 +0200 (CEST) Received: (qmail 27130 invoked by uid 500); 9 Apr 2020 04:35:23 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 27121 invoked by uid 99); 9 Apr 2020 04:35:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Apr 2020 04:35:23 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] zhiics commented on a change in pull request #5276: [REFACTOR][IR] Move to runtime::String Message-ID: <158640692315.17988.12480059988833264126.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 09 Apr 2020 04:35:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit zhiics commented on a change in pull request #5276: [REFACTOR][IR] Move to runtime::String URL: https://github.com/apache/incubator-tvm/pull/5276#discussion_r405950942 ########## File path: src/relay/transforms/device_annotation.cc ########## @@ -574,7 +574,7 @@ Pass RewriteAnnotatedOps(int fallback_device) { return Downcast(relay::RewriteAnnotatedOps(f, fallback_device)); }; return CreateFunctionPass(pass_func, 1, "RewriteAnnotatedOps", - {tir::StringImmNode::make("InferType")}); + {runtime::String("InferType")}); Review comment: I tried a bit more. It looks we actually need the constructor from `const char*` in order to make the initializer_list work. Previously, we only have the constructor from `std::string`. I will add it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services