From commits-return-10118-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Wed Apr 1 16:35:40 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A152E18064E for ; Wed, 1 Apr 2020 18:35:39 +0200 (CEST) Received: (qmail 40114 invoked by uid 500); 1 Apr 2020 16:35:39 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 40105 invoked by uid 99); 1 Apr 2020 16:35:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Apr 2020 16:35:38 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] masahi edited a comment on issue #5204: [Frontend][Torch] Fix up graph input handling Message-ID: <158575893885.6168.6828841080590168236.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 01 Apr 2020 16:35:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit masahi edited a comment on issue #5204: [Frontend][Torch] Fix up graph input handling URL: https://github.com/apache/incubator-tvm/pull/5204#issuecomment-607346078 I still like to retain the original meaning of `input_vars`, because this is really `relay.Var` and represents values that come from outside. `outputs` is for storing intermediate outputs from preceding relay ops. I think you can simply replace `input_vars` with `outputs` and also `inputs` with `outputs` everywhere. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services