tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #5491: Make "none" DataType explicit
Date Thu, 30 Apr 2020 20:17:29 GMT

kparzysz-quic commented on a change in pull request #5491:
URL: https://github.com/apache/incubator-tvm/pull/5491#discussion_r418263860



##########
File path: include/tvm/runtime/data_type.h
##########
@@ -211,6 +215,13 @@ class DataType {
   static DataType Handle(int bits = 64, int lanes = 1) {
     return DataType(kHandle, bits, lanes);
   }
+  /*!
+   * \brief Construct a None type.
+   * \return The constructed data type.
+   */
+  static DataType None() {

Review comment:
       I'm not sure what to do in `GetType`.  It checks for a pointer type, and for other
expressions it just returns the DataType member, so it seems like there is no extra handling
needed.
   
   Btw, the if statement doesn't seem to be doing anything, since it's followed by the exact
same return statement:
   https://github.com/apache/incubator-tvm/blob/master/src/tir/ir/op.cc#L61




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message