tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5491: Make "none" DataType explicit
Date Thu, 30 Apr 2020 19:57:39 GMT

tqchen commented on a change in pull request #5491:
URL: https://github.com/apache/incubator-tvm/pull/5491#discussion_r418253950



##########
File path: include/tvm/runtime/data_type.h
##########
@@ -211,6 +215,13 @@ class DataType {
   static DataType Handle(int bits = 64, int lanes = 1) {
     return DataType(kHandle, bits, lanes);
   }
+  /*!
+   * \brief Construct a None type.
+   * \return The constructed data type.
+   */
+  static DataType None() {

Review comment:
       to be consistent with the VoidType, perhaps we can use Void here? See also https://github.com/apache/incubator-tvm/blob/master/include/tvm/ir/type.h#L375
   
   Also need to update GetRuntimeType and GetType here https://github.com/apache/incubator-tvm/blob/master/include/tvm/tir/op.h#L60




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message