tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] Hzfengsy commented on pull request #5483: [TIR][Printer] text format printer considering future parsing use
Date Thu, 30 Apr 2020 12:44:17 GMT

Hzfengsy commented on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-621810131


   Some comments:
   1. There are more than one spaces before the left brace in the allocation line 
       ```
       allocate(B.local, float32, [64])  {
       ```
   
   2. Can we use the same rule for the allocation stmt as the one for attr? Allocation stmt
now will bring extra indentation
   
   3. ```
       attr [IterVar(blockIdx.z: int32, [(nullptr)], "ThreadIndex", "blockIdx.z")] "thread_extent"
= 196;
       ```
       It is strange to print `nullptr` here especially in square brackets. Perhaps we can
use `IterVar(blockIdx.z: int32, (nullptr), "ThreadIndex", "blockIdx.z")]` or `IterVar(blockIdx.z:
int32, , "ThreadIndex", "blockIdx.z")]`
   
   4. Considering future parsing use, we must print the dtype for every const number. But
we may use some shorthand for common dtype. e.g. `2f` for float32, `2h` for float16(half),
direct`2` for int32 (for here most integer numbers in schedule are int32). But still, keep
the complete form for every type. e.g. `int8(2)`, `float64(2)`(or may be `fp64(2)`) , also,
`float32(2)` is legal as well.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message