tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5423: [RUNTIME][OBJECT] Introduce static slots for common objects.
Date Fri, 24 Apr 2020 17:16:42 GMT

tqchen commented on a change in pull request #5423:
URL: https://github.com/apache/incubator-tvm/pull/5423#discussion_r414735177



##########
File path: include/tvm/ir/expr.h
##########
@@ -161,7 +163,8 @@ class RelayExprNode : public BaseExprNode {
   template<typename TTypeNode>
   inline const TTypeNode* type_as() const;
 
-  static constexpr const char* _type_key = "relay.Expr";
+  static constexpr const char* _type_key = "RelayExpr";

Review comment:
       This change is mainly for the Base class(given the c++ name is RelayExpr under the
root). The relay sub-classes are under the relay namespace.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message