tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] comaniac commented on issue #5409: [BYOC] Don't annotate constants
Date Wed, 22 Apr 2020 17:14:28 GMT

comaniac commented on issue #5409:
URL: https://github.com/apache/incubator-tvm/pull/5409#issuecomment-617912766


   Thanks for the PR, so the idea is to create the following graph if I understand correctly:
   
   ```
   input
     |
   begin
     |
    op -- const
     |
   end
   ```
   where the constant input for `op` is not annotated.
   
   Since now we require `AnnotateTarget` to annotate every op, and `AnnotateRegionSet`, `MergeCompilerRegion`
also require every op to be annotated, could you elaborate if this change works for all of
them? At first glance, it might be a problem for `AnnotateRegionSet` to identify the region
inputs.
   
   Following the above concern, could you also add this case to the unit tests of other passes
so that we can make sure the rest passes are covered.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message