tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice
Date Sun, 19 Apr 2020 23:56:15 GMT

kevinthesun commented on a change in pull request #4312:
URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r411021266



##########
File path: src/relay/transforms/fuse_ops.cc
##########
@@ -247,6 +247,28 @@ class IndexedForwardGraph::Creator : private ExprVisitor {
       this->Update(call->op, node, kOpaque);
     }
 
+    if (call->attrs.as<StridedSliceAttrs>()) {
+      bool is_dyn{false};
+      for (auto arg :  call->args) {
+        if (!arg.as<ConstantNode>()) {
+           is_dyn = true;
+           break;
+        }
+        auto arg_tt = arg->checked_type().as<TensorTypeNode>();
+        if (arg_tt) {

Review comment:
       Since we have already checked begin, end and stride through as<ConstantNode>,
I think here we just need to check the first arg?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message