tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5367: Improve IntervalSet's floormod
Date Sun, 19 Apr 2020 16:56:05 GMT
tqchen commented on a change in pull request #5367: Improve IntervalSet's floormod
URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r410945718
 
 

 ##########
 File path: src/arith/int_set.cc
 ##########
 @@ -372,7 +387,27 @@ class IntervalSetEvaluator :
   }
 
   IntervalSet Eval(const PrimExpr& val) {
-    return this->VisitExpr(val);
+    IntervalSet result = this->VisitExpr(val);
 
 Review comment:
   Ideally we do not want to add an additional case here, as it could recursive , perhaps
need more thoughts

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message