tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen edited a comment on issue #5367: Improve IntervalSet's floormod
Date Sun, 19 Apr 2020 16:53:05 GMT
tqchen edited a comment on issue #5367: Improve IntervalSet's floormod
URL: https://github.com/apache/incubator-tvm/pull/5367#issuecomment-616178512
 
 
   It would be great if we can dissect it down to specific cases in mind and discuss how to
solve these cases, I see two kinds of problems:
   
   - (1) EvalSet need to be aware of the bound of Vars
      - Ideally these bounds should be populated in the analyzer via bind.
   - (2) `floormod([13, 15], 10) => [3, 5]` : This seems to be a clean case that we can
fix first(independent from the Var bound problem), how about we create a separate PR for the
var bound case and aim at fixing this one?
      - The fix would be `floormod([a, b], c)` , check if we can prove `floordiv(a, c) ==
floordiv(b, c)`, if so, we rewrite to `[a - floordiv(a, c) * c, b -  floordiv(b, c) * c]`,
otherwise, follow the old rule.
   
   
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message