tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] comaniac commented on issue #5277: [BYOC] Refine AnnotateTarget and MergeCompilerRegion Passes
Date Wed, 15 Apr 2020 16:48:53 GMT
comaniac commented on issue #5277: [BYOC] Refine AnnotateTarget and MergeCompilerRegion Passes
URL: https://github.com/apache/incubator-tvm/pull/5277#issuecomment-614153285
 
 
   One reason that I exposed default between passes was to have a clear task division so that
the flow would be more stable. For example, one bug about composite function reported in #5272
was because AnnotateTarget pass skipped composite functions but AnnotateRestDefault didn't,
so the default annotations were mis-inserted and it results in segmentation fault when partitioning
the graph. This may happen in the future if still we have more than one places doing similar
tasks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message