tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] manupa-arm commented on issue #5277: [BYOC] Refine AnnotateTarget and MergeCompilerRegion Passes
Date Wed, 15 Apr 2020 10:06:49 GMT
manupa-arm commented on issue #5277: [BYOC] Refine AnnotateTarget and MergeCompilerRegion Passes
URL: https://github.com/apache/incubator-tvm/pull/5277#issuecomment-613946486
 
 
   Sorry for the late comments ( I was out for a week ). 
   
   Among the bug fixes (e.g., type propogation in tuple bug) and new functionalities (e.g.,
supporting a list of targets in AnnotateTarget), this PR had technically moved (and improved)
AnnotateRestDefault to AnnotateTarget and moved the removal of defaults to PartitionGraph.

   
   IIRC, the defaults were a requirement of the MergeCompilerRegions pass and thats why they
were inside MCR ? I just want to understand the rationale as to why you think they should
moved as such and potentially exposing them ("defaults") in the graph that is being passed
among passes? 
   
   PS : I agree with @zhiics that this pass do not change the flow and agree with the most
of the fixes that are brought in alongside the moving of "default" related components, though
ideally should have been better if they were seperate PRs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message