tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] FrozenGene commented on issue #4857: Windows Support for cpp_rpc
Date Wed, 15 Apr 2020 04:03:37 GMT
FrozenGene commented on issue #4857: Windows Support for cpp_rpc
URL: https://github.com/apache/incubator-tvm/pull/4857#issuecomment-613803362
 
 
   > > For CMake version, It is better to use the same version on Linux / Windows. We
cold add it in compiler options in later pr.
   > 
   > Removed all the extra CMakeLists.txt stuff I had in there and do a FATAL if USE_CPP_RPC
is set on a non-Windows platform.
   > 
   > Added instructions in the README.
   > 
   > Two other things I want to check with you guys is the small modification I made to
`src/support/ring_buffer.h`. The original would cause a crash on Windows.
   > 
   > Also the same with `src/runtime/rpc/rpc_socket_impl.cc` change, which shouldn't be
an issue (put try/catch in a destructor).
   
   i think it is fine

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message